Skip to content

[Assets] Accept empty base_url, in order to simplify local dev configuration. #44150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2021

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Nov 19, 2021

Q A
Branch? 6.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #28391
License MIT
Doc PR -

@carsonbot carsonbot added this to the 6.0 milestone Nov 19, 2021
@GromNaN GromNaN changed the title [Assets] Accepts empty base_url, in order to simplify local dev configuration. [Assets] Accept empty base_url, in order to simplify local dev configuration. Nov 19, 2021
@GromNaN GromNaN modified the milestones: 6.0, 6.1 Nov 20, 2021
@GromNaN GromNaN requested review from weaverryan and xabbuh November 25, 2021 10:37
@GromNaN GromNaN changed the base branch from 6.0 to 6.1 November 29, 2021 16:32
@fabpot fabpot force-pushed the 6.1-assets-empty-base-url branch from 71c9755 to e3ac469 Compare December 11, 2021 15:18
@fabpot
Copy link
Member

fabpot commented Dec 11, 2021

Thank you @GromNaN.

@fabpot fabpot merged commit 5211e18 into symfony:6.1 Dec 11, 2021
@GromNaN GromNaN deleted the 6.1-assets-empty-base-url branch April 4, 2022 11:03
@fabpot fabpot mentioned this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC][Asset] Assets Base Path Should Support Empty Values
3 participants