Skip to content

[FrameworkBundle] Add semaphore configuration #44155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

jderusse
Copy link
Member

Q A
Branch? 6.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR TODO

Adds a new configuration for semaphores

# see https://symfony.com/doc/current/reference/configuration/framework.html
framework:
    semaphore: redis://localhost
    semaphore: 
      foo: redis://localhost/1
      bar: redis://localhost/2

@carsonbot carsonbot added this to the 6.0 milestone Nov 20, 2021
@jderusse jderusse removed this from the 6.0 milestone Nov 20, 2021
@fabpot fabpot added this to the 6.1 milestone Nov 21, 2021
@jderusse jderusse changed the base branch from 6.0 to 6.1 December 2, 2021 17:21
@fabpot
Copy link
Member

fabpot commented Mar 26, 2022

@jderusse Is it ready to be merged? Is yes, can you rebase?

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(with one question)

@fabpot
Copy link
Member

fabpot commented Apr 12, 2022

@jderusse Last chance for 6.1 :)

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Let's fix the code for lock on 4.4

@nicolas-grekas
Copy link
Member

Thank you @jderusse.

@nicolas-grekas nicolas-grekas merged commit ce3564b into symfony:6.1 Apr 12, 2022
nicolas-grekas added a commit that referenced this pull request Apr 12, 2022
…on (jderusse)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] Fix env resolution in lock configuration

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | /
| License       | MIT
| Doc PR        | /

Fix wrong value injected in lock factory. See #44155 (comment)

Commits
-------

c1a9af7 Fix env resolution in lock configuration
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Apr 12, 2022
…on (jderusse)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] Fix env resolution in lock configuration

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | /
| License       | MIT
| Doc PR        | /

Fix wrong value injected in lock factory. See symfony/symfony#44155 (comment)

Commits
-------

c1a9af7a0b Fix env resolution in lock configuration
@jderusse jderusse deleted the fwb-semaphore branch April 12, 2022 10:37
@fabpot fabpot mentioned this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants