[Config] added EnumNode #4420
Merged
[Config] added EnumNode #4420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
that referenced
this pull request
May 26, 2012
Commits ------- 8308aea [Config] added EnumNode Discussion ---------- [Config] added EnumNode This adds an EnumNode which should be used instead of a Closure and manual validation. The benefit is that you can retrieve the allowed values. It is also a bit shorter, but that is not the main point here. --------------------------------------------------------------------------- by travisbot at 2012-05-26T03:52:50Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1439264) (merged 8308aea into ff4d446).
| throw new \InvalidArgumentException('->values() must be called with at least two distinct values.'); | ||
| } | ||
|
|
||
| $this->values = $values; |
There was a problem hiding this comment.
I recommend, that you do a PR if this is till an issue. Also note, that you have to do a PR against the branch this feature was introduced in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an EnumNode which should be used instead of a Closure and manual validation.
The benefit is that you can retrieve the allowed values. It is also a bit shorter, but that is not the main point here.