[Console] Add Suggestion class for more advanced completion suggestion #44230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
commented
Nov 23, 2021
src/Symfony/Component/Console/Completion/CompletionSuggestions.php
Outdated
Show resolved
Hide resolved
8aedd66 to
f5667b0
Compare
stof
requested changes
Nov 23, 2021
src/Symfony/Component/Console/Completion/CompletionSuggestions.php
Outdated
Show resolved
Hide resolved
f5667b0 to
607be82
Compare
607be82 to
20ba02c
Compare
nicolas-grekas
approved these changes
Nov 23, 2021
GromNaN
approved these changes
Nov 23, 2021
welcoMattic
approved these changes
Nov 23, 2021
ogizanagi
approved these changes
Nov 23, 2021
stof
reviewed
Nov 23, 2021
| { | ||
| private $valueSuggestions = []; | ||
| private $optionSuggestions = []; | ||
|
|
||
| /** | ||
| * Add a suggested value for an input option or argument. | ||
| * | ||
| * @param string|Suggestion $value |
There was a problem hiding this comment.
should be changed to a native union type when merging into 6.0
|
Thank you @wouterj. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #44229 , see that PR for the full context.