[Processor] Fix environment string value problem #44257
Conversation
Some libs send $env argument as string
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
I'm sorry but the patch doesn't make sense. |
| foreach ($env as $k => $v) { | ||
| if (false !== $v && 'argc' !== $k && 'argv' !== $k) { | ||
| $envPairs[] = $k.'='.$v; | ||
| if(\is_array($env)){ |
There was a problem hiding this comment.
The code says everywhere that env should be an array, here most likely you need to think about the explicit merging of two arrays, and not about checking for an array.
Some libs send $env argument as string
Sometimes environment come as string, generally from old libraries