Skip to content

[Notifier] Fix AllMySms bridge body content #44277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2021
Merged

[Notifier] Fix AllMySms bridge body content #44277

merged 1 commit into from
Nov 25, 2021

Conversation

afiocre
Copy link
Contributor

@afiocre afiocre commented Nov 25, 2021

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #44276
License MIT

Fix the 1005 error code from AllMySms bridge with Notifier component

@afiocre afiocre requested a review from OskarStark as a code owner November 25, 2021 15:35
@carsonbot carsonbot added this to the 5.3 milestone Nov 25, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@afiocre afiocre force-pushed the fix/allmysms-1005-error-code branch from d1d7656 to 376b3e5 Compare November 25, 2021 16:05
fancyweb
fancyweb approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@fancyweb fancyweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://doc.allmysms.com/api/en/#introduction

The body of the requests should be in JSON format

@fabpot
Copy link
Member

fabpot commented Nov 25, 2021

Thank you @afiocre.

@fabpot fabpot merged commit c236dfe into symfony:5.3 Nov 25, 2021
@afiocre afiocre deleted the fix/allmysms-1005-error-code branch November 26, 2021 07:59
This was referenced Nov 29, 2021
Merged
Merged
@fabpot fabpot mentioned this pull request Dec 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@fancyweb fancyweb fancyweb approved these changes

@cbarrancolrqdo cbarrancolrqdo cbarrancolrqdo approved these changes

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

Assignees
No one assigned
Labels
Bug Notifier Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
6 participants
@afiocre @carsonbot @fabpot @nicolas-grekas @fancyweb @cbarrancolrqdo