[HttpClient] Fix handling error info in MockResponse #44361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e2125b8 to
d122b38
Compare
fancyweb
commented
Nov 30, 2021
fancyweb
commented
Nov 30, 2021
|
|
||
| $responses[] = $mock; | ||
| $responses[] = $mock; | ||
| $responses[] = $mockResponse = new MockResponse('', ['error' => 'DNS error']); |
There was a problem hiding this comment.
We don't need to mock anymore because getStatusCode() will throw properly.
fancyweb
commented
Nov 30, 2021
| $mock->expects($this->any()) | ||
| ->method('getContent') | ||
| ->willReturnCallback(static function (): void { | ||
| usleep(100000); |
There was a problem hiding this comment.
This usleep was useless.
d122b38 to
784edde
Compare
784edde to
369d9d7
Compare
|
Thank you @fancyweb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
new MockResponse('', ['error' => 'foobar'])with theMockHttpClient, I expect aTransportExceptionto be thrown if I callgetStatusCode(),getHeaders(),getContent()ortoArray().Currently, it does not work for
getStatusCode()andgetHeaders()becauseMockResponseonly "converts" the passed error to an exception after the full response workflow has been simulated.getStatusCode()andgetHeaders()stops at the first chunk so it cannot work. I propose to throw at the beginning of the simulated response reading.