[HttpClient] Fix handling thrown \Exception in \Generator in MockResponse #44438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fancyweb
commented
Dec 3, 2021
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
810e8a6 to
6ba7548
Compare
|
Failure is related, I need to investigate. |
|
@nicolas-grekas The failure is related to the PHP version. It seems that the destructor of |
3beaf09 to
f2867f4
Compare
f2867f4 to
c71265b
Compare
fancyweb
commented
Dec 11, 2021
| @@ -167,7 +210,7 @@ protected function getHttpClient(string $testCase): HttpClientInterface | |||
| case 'testResolve': | |||
| $responses[] = new MockResponse($body, ['response_headers' => $headers]); | |||
| $responses[] = new MockResponse($body, ['response_headers' => $headers]); | |||
| $responses[] = new MockResponse((function () { throw new \Exception('Fake connection timeout'); yield ''; })(), ['response_headers' => $headers]); | |||
| $responses[] = new MockResponse((function () { yield ''; })(), ['response_headers' => $headers]); | |||
There was a problem hiding this comment.
We don't need to throw for the test to be effective. Yielding after throwing "breaks" PHP 7.2.
nicolas-grekas
approved these changes
Dec 11, 2021
|
Thank you @fancyweb. |
This was referenced Dec 29, 2021
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.