Skip to content

[Security] Allow RememberMeHandler to use a custom RememberMeDetails class #44459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: 7.4
Choose a base branch
from
+159 −7
Open

[Security] Allow RememberMeHandler to use a custom RememberMeDetails class #44459

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ce7b8d4
[Security] [RememberMe] Allow RememberMeHandlers to use custom Rememb…
Dec 4, 2021
84ddcf3
update CHANGELOG
Dec 4, 2021
3489e4d
fix coding standards
Dec 4, 2021
5dc714d
properly indent virtual method description
Dec 4, 2021
c8c3297
Add and modify tests for custom RememberMeDetails support
Dec 4, 2021
09bd6c1
Create UPGRADE-7.0.md file
Dec 8, 2021
99b49d0
Remove unnecessary deprecations and add tests to legacy group
Dec 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update CHANGELOG
  • Loading branch information
Patrick Elshof committed Jun 6, 2022
commit 84ddcf33cf58e9aa8e6746047055dce1aa243d1f
6 changes: 6 additions & 0 deletions UPGRADE-6.2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,9 @@ Validator
---------

* Deprecate the "loose" e-mail validation mode, use "html5" instead

Security
--------

* Deprecate `RememberMeHandler` not implementing `getUserIdentifierForCookie()`; `AbstractRememberMeHandler` has a default implementation
* Deprecate `RememberMeHandler` not implementing `getRememberMeDetails()`; `AbstractRememberMeHandler` has a default implementation
2 changes: 2 additions & 0 deletions src/Symfony/Bundle/SecurityBundle/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ CHANGELOG
---

* Add the `Security` helper class
* Add the `getUserIdentifierForCookie()` method to the `Symfony\Bundle\SecurityBundle\RememberMe\DecoratedRememberMeHandler`
and `Symfony\Bundle\SecurityBundle\RememberMe\FirewallAwareRememberMeHandler` classes

6.1
---
Expand Down
8 changes: 8 additions & 0 deletions src/Symfony/Component/Security/Http/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
CHANGELOG
=========

6.2
---

* Deprecate `RememberMeHandler` not implementing `getUserIdentifierForCookie()`; `AbstractRememberMeHandler` has a default implementation
* Deprecate `RememberMeHandler` not implementing `getRememberMeDetails()`; `AbstractRememberMeHandler` has a default implementation
* Add `getRememberMeDetails()` method to `Symfony\Component\Security\Http\RememberMe\AbstractRememberMeHandler`
* Add `getUserIdentifierForCookie()` method to `Symfony\Component\Security\Http\RememberMe\AbstractRememberMeHandler`

6.0
---

Expand Down