Skip to content

[Console] Fix parameter types for ProcessHelper::mustRun() #44467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2021

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Dec 5, 2021

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

The mustRun() method wraps the run() method and therefor must accepts the same parameter types. However, mustRun() claims to accept a string as $cmd while run() requires it to be an array.

This PR fixes the incorrect doc block.

@derrabus derrabus force-pushed the bugfix/process-helper-type branch from 871e6d5 to c1c8c20 Compare December 5, 2021 16:01
@fabpot
Copy link
Member

fabpot commented Dec 5, 2021

Thank you @derrabus.

@fabpot fabpot merged commit 53a45b2 into symfony:4.4 Dec 5, 2021
@derrabus derrabus deleted the bugfix/process-helper-type branch December 5, 2021 17:39
This was referenced Dec 9, 2021
This was referenced Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants