Skip to content

[Translation] [Bridge] [Lokalise] Fix push keys to lokalise. Closes #… #44474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2021
Merged

[Translation] [Bridge] [Lokalise] Fix push keys to lokalise. Closes #… #44474

merged 1 commit into from
Dec 11, 2021

Conversation

olegmifle
Copy link
Contributor

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #44444
License MIT
Doc PR N/A

Fixed issue in #44444 within fix some other problems e.g.

  • localise GET method "keys" return only 100 keys per request by default, max 5000. Fixed it and get all the available keys.
  • localise recommend update\create only 500 keys per request but service refuse another chank with error "Your token is currently used to process another request. We do not support concurrent requests.". So I send all keys in one request and it works fine.
  • add return types to some methods

@carsonbot carsonbot added this to the 5.3 milestone Dec 6, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@olegmifle olegmifle requested a review from stof December 8, 2021 06:55
@fabpot
Copy link
Member

fabpot commented Dec 11, 2021

Thank you @olegmifle.

@fabpot fabpot merged commit 3b6cc05 into symfony:5.3 Dec 11, 2021
This was referenced Dec 29, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@stof stof Awaiting requested review from stof

Assignees
No one assigned
Labels
Bug Status: Reviewed Translation
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
4 participants
@olegmifle @carsonbot @fabpot @stof