[HttpClient] Double check if handle is complete #44479
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a forward compatibility fix. We did the same in Guzzle after a comment from bagder.
guzzle/guzzle#2892 (comment)
Basically, if libcurl decides to add an other value for
msg
, then our code will break without this PR. The only value formsg
with current latest version of curl isCURLMSG_DONE
which means that this is not a bugfix yet.. but it make sure that we respect the libcurl API.