Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Hey!

I think @a-shafaat has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

This should be considered a bug fix, and merged in 5.4 i suppose.

This should be considered a bug fix, and merged in 5.4 I suppose.

@azjezz so I must remove this PR and create a new one on the 5.4 repo? I don't know that 6.1 is just for new features.

All translations are actually backported to the lowest maintained branch (4.4 atm) so you can just change the target branch to 4.4 and there shouldn't be any conflict.

Thank you @mostafazs!

As you created the PR on the 6.1 branch of your fork, I took your commit and created a new PR to 4.4: #44591 We'll merge it to 6.1 from there.

For your next contribution, it is recommended that you create a new branch for each PR (see the contributing docs). A PR is always between a branch in your fork and the main repository. Having a separate branch for each PR allows to work on more than 1 PR at the same time. And it makes sure you can freely change the base version without changing the 6.1 branch in your fork.

However, as I only took your commit, you're still the full author of this change. All credits (and badges) to you and hope to see you back another time!