Skip to content

[Messenger] add TransportMessageIdStamp to RedisSender #44522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2022
Merged

[Messenger] add TransportMessageIdStamp to RedisSender #44522

merged 1 commit into from
Mar 6, 2022

Conversation

GaryPEGEOT
Copy link
Contributor

@GaryPEGEOT GaryPEGEOT commented Dec 9, 2021 •
edited
Loading

Q A
Branch? 6.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR

@carsonbot carsonbot added this to the 5.4 milestone Dec 9, 2021
@fabpot fabpot modified the milestones: 5.4, 6.1 Dec 9, 2021
@fabpot
Copy link
Member

fabpot commented Dec 9, 2021

That's a new feature :)

@GaryPEGEOT
Copy link
Contributor Author

That's a new feature :)

Worth a shot 😄 ! I've changed the target branch

@GaryPEGEOT GaryPEGEOT changed the base branch from 5.4 to 6.1 December 9, 2021 13:11
nicolas-grekas
nicolas-grekas reviewed Mar 4, 2022
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there is a failure to fix in the CI

@GaryPEGEOT GaryPEGEOT force-pushed the redis-msg-id-stamp branch from d15b8ff to d820dd4 Compare March 5, 2022 11:01
@GaryPEGEOT
Copy link
Contributor Author

@nicolas-grekas fixed!

@nicolas-grekas
Copy link
Member

Thank you @GaryPEGEOT.

@nicolas-grekas nicolas-grekas mentioned this pull request Mar 6, 2022
Closed
@nicolas-grekas nicolas-grekas merged commit 77ec2ad into symfony:6.1 Mar 6, 2022
@fabpot fabpot mentioned this pull request Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@jderusse jderusse Awaiting requested review from jderusse

@lyrixx lyrixx Awaiting requested review from lyrixx

@OskarStark OskarStark Awaiting requested review from OskarStark

@wouterj wouterj Awaiting requested review from wouterj

@xabbuh xabbuh Awaiting requested review from xabbuh

@yceruto yceruto Awaiting requested review from yceruto

Assignees
No one assigned
Labels
Messenger Status: Needs Review
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
4 participants
@GaryPEGEOT @fabpot @nicolas-grekas @carsonbot