PSR Container dependency version fix for 5.3 & 5.4 #44561
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
requested changes
Dec 11, 2021
| @@ -39,7 +39,7 @@ | |||
| "doctrine/persistence": "^2", | |||
| "twig/twig": "^2.13|^3.0.4", | |||
| "psr/cache": "^1.0|^2.0", | |||
| "psr/container": "^1.0", | |||
| "psr/container": "^1.1|^2.0", | |||
There was a problem hiding this comment.
Because DI does not support 2.0, this should actually be "^1.1.1" as in the DependencyInjection composer.json file.
|
As @fabpot explained, we cannot do this on 5.x. On 6.0 however, this change has been made already. Let's close, thanks for proposing. |
derrabus
added a commit
that referenced
this pull request
Dec 13, 2021
…ix for 5.3 & 5.4 (Nek-) This PR was merged into the 5.3 branch. Discussion ---------- [DependencyInjection] PSR Container dependency version fix for 5.3 & 5.4 | Q | A | ------------- | --- | Branch? | 5.3 / 5.4 | Bug fix? | somehow | New feature? | no | Deprecations? | no | License | MIT <!-- Replace this notice by a short README for your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch 5.x. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> This problem is already solved on Sf 6.0 branch and also on the component itself but for 5.4 and 5.3 if you install with `--prefer-lowest` for `symfony/symfony` package, it will install a wrong version of psr container. Updated from #44561 with `@fabpot` feedbacks. `@derrabus` see the correct version here: https://github.com/symfony/symfony/blob/5.3/src/Symfony/Component/DependencyInjection/composer.json#L20 Commits ------- b7644bd fix: lowest version of psr container supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem is already solved on Sf 6.0 branch and also on the component itself but for 5.4 and 5.3 if you install with
--prefer-lowestforsymfony/symfonypackage, it will install a wrong version of psr container.I hope this helps!