[FrameworkBundle] Use correct cookie domain in loginUser() #44565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Dec 11, 2021
|
Thank you @wouterj. |
|
@wouterj thankyou very much, confirmed this works. any idea where the regression/bug/change crept in? |
|
Thanks @wouterj 🚀 |
This was referenced Dec 29, 2021
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon each request, we parse the cookie header from the response. This means that after a first request in the test, the session cookie has a domain (localhost), instead of
''. This breaks callingloginUser()with another user for a subsequent test.This PR fixes this by discovering if there are already session cookies set for a specific domain, and then overriding that session.