Skip to content

[Messenger] Added generic template for Envelope::last() method #44583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2021
Merged

[Messenger] Added generic template for Envelope::last() method #44583

merged 1 commit into from
Dec 17, 2021

Conversation

fractalzombie
Copy link
Contributor

@fractalzombie fractalzombie commented Dec 12, 2021 •
edited by derrabus
Loading

Q A
Branch? 6.1
Bug fix? no
New feature? no
Deprecations? no
License MIT

Added possibility to PHPStorm generic support for Envelope::last method, no need more /** @var SomeStampClass */

@carsonbot carsonbot added this to the 5.4 milestone Dec 12, 2021
@fractalzombie
Copy link
Contributor Author

Maybe someone can review?)

@derrabus
Copy link
Member

Let's target 6.1 please.

@derrabus derrabus modified the milestones: 5.4, 6.1 Dec 15, 2021
@derrabus derrabus changed the base branch from 5.4 to 6.1 December 15, 2021 17:21
@derrabus
Copy link
Member

Can you please rebase onto 6.1? I think Psalm is confused by the 5.4 compat layer that should be gone on the 6.1 branch.

@fractalzombie
Copy link
Contributor Author

Can you please rebase onto 6.1? I think Psalm is confused by the 5.4 compat layer that should be gone on the 6.1 branch.

Done

@derrabus
Copy link
Member

Okay, that didn't help. But nevermind, I think we can ignore the Psalm error as a false positive. Psalm apparently does not fully understand the stamps array and I think that's okay.

@fractalzombie
Copy link
Contributor Author

Okay, that didn't help. But nevermind, I think we can ignore the Psalm error as a false positive. Psalm apparently does not fully understand the stamps array and I think that's okay.

Yep, I think this is false positive.

@nicolas-grekas
Copy link
Member

Thank you @fractalzombie.

@nicolas-grekas nicolas-grekas merged commit a976d27 into symfony:6.1 Dec 17, 2021
@Bilge
Copy link
Contributor

Bilge commented Feb 1, 2022

Can we get a backport on this to 5.4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Messenger Status: Reviewed
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
5 participants
@fractalzombie @derrabus @nicolas-grekas @Bilge @carsonbot