[DependencyInjection] PSR Container dependency version fix for 5.3 & 5.4 #44586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Dec 13, 2021
But… you don't depend on Anyway, this change looks correct. |
|
@derrabus it can be convenient for testing. |
|
No, trust me on this. Please don't. |
stof
approved these changes
Dec 13, 2021
|
Thank you @Nek-. |
Nek-
added a commit
to Nek-/Melodiia
that referenced
this pull request
Dec 17, 2021
This was a fix due to an issue inside Sf 5.3, fixed by symfony/symfony#44586
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem is already solved on Sf 6.0 branch and also on the component itself but for 5.4 and 5.3 if you install with
--prefer-lowestforsymfony/symfonypackage, it will install a wrong version of psr container.Updated from #44561 with @fabpot feedbacks.
@derrabus see the correct version here: https://github.com/symfony/symfony/blob/5.3/src/Symfony/Component/DependencyInjection/composer.json#L20