[Messenger] add SerializedMessageStamp #44589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I think @monteiro has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
ogizanagi
approved these changes
Dec 30, 2021
|
hi @ogizanagi I also rebased on 6.1 |
kbond
approved these changes
Dec 31, 2021
chalasr
approved these changes
Dec 31, 2021
|
Thank you @nikophil. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #43496
When a message is sent for retry, we currently serialize it from the message POPO object whereas we already had the serialized representation of the message before deserializing it.
This solution proposes to store the serialized message in a "not serializable" stamp when we receive the message. Then the serialized message will be used in
\Symfony\Component\Messenger\Transport\Serialization\Serializer::encode(), if the message is retried, which prevents to serialize the message again.This has several advantages, mainly when we're dealing with big payloads: