[HttpClient] Fix closing curl-multi handle too early on destruct #44601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b393154 to
35d57ee
Compare
35d57ee to
cdf9ab2
Compare
|
is it possible to have tests to prevent such regressions or is it too tricky to trigger ? |
|
It's too tricky, PHP engine closing in unpredictable order... |
cdf9ab2 to
f065f97
Compare
f065f97 to
c0602fd
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Dec 14, 2021
…) (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] fix monitoring responses issued before reset() | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Follow up of #44601 In order to reset the DNS cache, we have to create a new curl-multi handle. But since there might still be responses attached to the previous handle, we need to keep it around to monitor it. Best reviewed [ignoring whitespaces](https://github.com/symfony/symfony/pull/44625/files?w=1). Commits ------- 6e52960 [HttpClient] fix monitoring responses issued before reset()
This was referenced Dec 29, 2021
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the garbage collector can decide to destruct the
CurlClientStatebefore the responses that reference them.When this happens, the curl-multi handle is closed and responses end up in a broken state.
This fixes it by not closing the multi-handle on destruct/reset.
This also fixes configuring the multi-handle on reset.