[HttpClient] fix monitoring responses issued before reset() #44625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44d0f0e to
438c18c
Compare
stof
reviewed
Dec 14, 2021
| @@ -325,7 +335,7 @@ private static function select(ClientState $multi, float $timeout): int | |||
| $timeout = min($timeout, 0.01); | |||
| } | |||
|
|
|||
| return curl_multi_select($multi->handle, $timeout); | |||
| return curl_multi_select($multi->handle[array_key_last($multi->handle)], $timeout); | |||
There was a problem hiding this comment.
why the last key rather than the first one ?
There was a problem hiding this comment.
Because the last handle is one for which we're sure there is pending activity (since handles past the 0 one are all removed when they're empty).
16fe114 to
7506401
Compare
7506401 to
6e52960
Compare
This was referenced Dec 29, 2021
Merged
Merged
Merged
Merged
nicolas-grekas
added a commit
to nicolas-grekas/symfony
that referenced
this pull request
Jan 13, 2022
This PR reverts symfony#44625 and uses a new curl-share handle instead to reset any state.
nicolas-grekas
added a commit
to nicolas-grekas/symfony
that referenced
this pull request
Jan 13, 2022
This PR reverts symfony#44625 and uses a new curl-share handle instead to reset any state.
nicolas-grekas
added a commit
to nicolas-grekas/symfony
that referenced
this pull request
Jan 13, 2022
This PR reverts symfony#44625 and uses a new curl-share handle instead to reset any state.
nicolas-grekas
added a commit
that referenced
this pull request
Jan 14, 2022
…ient::reset() (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] fix resetting DNS/etc when calling CurlHttpClient::reset() | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #44900 | License | MIT | Doc PR | - This PR reverts #44625 and uses a new curl-share handle instead to reset any state. Commits ------- d426646 [HttpClient] fix resetting DNS/etc when calling CurlHttpClient::reset()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #44601
In order to reset the DNS cache, we have to create a new curl-multi handle. But since there might still be responses attached to the previous handle, we need to keep it around to monitor it.
Best reviewed ignoring whitespaces.