[HttpKernel] Set session cookie only when not empty #44657
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43c83f5 to
3e4a8df
Compare
3e4a8df to
e89eb3a
Compare
| @@ -151,7 +151,8 @@ public function onKernelResponse(ResponseEvent $event) | |||
| $request = $event->getRequest(); | |||
| $requestSessionCookieId = $request->cookies->get($sessionName); | |||
|
|
|||
| if ($requestSessionCookieId && $session->isEmpty()) { | |||
| $isSessionEmpty = $session->isEmpty(); | |||
There was a problem hiding this comment.
Need in 6.0 be replaced with the new logic:
|
Hey! I think @mtarld has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
| @@ -160,7 +161,7 @@ public function onKernelResponse(ResponseEvent $event) | |||
| $sessionCookieHttpOnly, | |||
| $sessionCookieSameSite | |||
| ); | |||
| } elseif ($sessionId !== $requestSessionCookieId) { | |||
| } elseif ($sessionId !== $requestSessionCookieId && !$isSessionEmpty) { | |||
There was a problem hiding this comment.
maybe we should even not write the session in the backend when it's empty?
There was a problem hiding this comment.
If a value is removed we need to write it to remove that value from the session bag.
|
for making things simpler for me I moving this changes to #44634 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A session is normally not written when empty so we need to check for empty before set the session cookie.
TODO: