[FrameworkBundle] Add @return TestContainer to KernelTestCase::getContainer() #44695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a BC break, but we can do it by using |
8f8682b to
e7730dc
Compare
|
Damn I was sure this class was internal 😅 I tested with |
|
One test to fix and good to me. |
fbbe6b9 to
f36e6f3
Compare
f36e6f3 to
a6bc80c
Compare
a6bc80c to
812619c
Compare
This was referenced May 28, 2022
nicolas-grekas
added a commit
that referenced
this pull request
May 30, 2022
…rnal class (xabbuh) This PR was merged into the 6.1 branch. Discussion ---------- [FrameworkBundle] update docblock to not expose the internal class | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #46483 | License | MIT | Doc PR | The change was introduced in #44695 motivated by the idea to be able to use the `getServiceIds()` and `getRemovedIds()` methods which are Symfony-specific methods. Exposing the `TestContainer` has the drawback of static analysis tools complaining about making use of internal classes. Since the interesting methods are part of the base `Container` class which is not internal I propose to change the docblock to return an instance of this class instead. Commits ------- f30db82 update docblock to not expose the internal class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I understood,
test.service_containercan only be an instance ofTestContainer. Changing the return type allows autocompletion for useful methods such asgetServiceIds()andgetRemovedIds()(I didn't understand why they didn't showed up in my test). That's a DX improvement, can it be applied on a lower branch?