Skip to content

[DependencyInjection] fix linting callable classes #44710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2021

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #44356
License MIT
Doc PR -

@carsonbot carsonbot added this to the 4.4 milestone Dec 19, 2021
@nicolas-grekas nicolas-grekas changed the title [DependencyInjection] Cast tag value to string [DependencyInjection] fix linting callable classes Dec 19, 2021
@chalasr
Copy link
Member

chalasr commented Dec 19, 2021

Thank you @nicolas-grekas.

@chalasr chalasr merged commit 4ebeb89 into symfony:4.4 Dec 19, 2021
@nicolas-grekas nicolas-grekas deleted the di-call branch December 24, 2021 13:53
nicolas-grekas added a commit that referenced this pull request Oct 22, 2024
…a __callStatic (KevinVanSonsbeek)

This PR was squashed before being merged into the 5.4 branch.

Discussion
----------

[DependencyInjection] Fix linting factories implemented via __callStatic

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #58614
| License       | MIT

This PR is an extension of an old fix made back in #44710.
Factory calls to static methods handled by the `__callStatic` method currently throw the "Invalid service DYZ: method Class::method() does not exist".

Commits
-------

e2f69af [DependencyInjection] Fix linting factories implemented via __callStatic
symfony-splitter pushed a commit to symfony/dependency-injection that referenced this pull request Oct 22, 2024
…a __callStatic (KevinVanSonsbeek)

This PR was squashed before being merged into the 5.4 branch.

Discussion
----------

[DependencyInjection] Fix linting factories implemented via __callStatic

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #58614
| License       | MIT

This PR is an extension of an old fix made back in symfony/symfony#44710.
Factory calls to static methods handled by the `__callStatic` method currently throw the "Invalid service DYZ: method Class::method() does not exist".

Commits
-------

e2f69af6bd3 [DependencyInjection] Fix linting factories implemented via __callStatic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants