[Process] Run open_basedir tests in separate processes
#44711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
open_basedir tests in separate processesopen_basedir tests in separate processes
|
Thank you @julienfalque. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #43239, I noticed that when a test sets
open_basedir, the setting is not reset to its initial value after the test, which can have an impact on subsequent tests. I could not find the reason why the setting cannot be reset. I assume this is for security reasons, so the solution is to always run such test in a separate process.This only concerns two tests for now. Before running those in separate process, the first one prevented subsequent tests in the same class from being run because they are skipped when
open_basediris set, which was always true.