[Serializer] Deprecate support for abstract uid denormalization in UidNormalizer #44721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cffe3b8 to
09000e1
Compare
stof
reviewed
Dec 20, 2021
src/Symfony/Component/Serializer/Tests/Normalizer/UidNormalizerTest.php
Outdated
Show resolved
Hide resolved
|
(rebase needed) |
09000e1 to
8661042
Compare
38431ca to
4075944
Compare
4075944 to
b0c07f8
Compare
ro0NL
reviewed
Jan 13, 2022
Comment on lines
+11
to
+28
| * Deprecate supporting denormalization for `AbstractUid` in `UidNormalizer`, use one of `AbstractUid` child class instead | ||
| * Deprecate denormalizing to an abstract class in `UidNormalizer` |
There was a problem hiding this comment.
to me this signals the same deprecation
There was a problem hiding this comment.
There is one deprecation for supportsDenormalization() that will return false instead of true for AbstractUid::class specifically.
And another for denormalize() that will throw an \Error if the class is abstract (instead of fallbacking to Uuid::class).
793a7b2 to
6ed7a68
Compare
6ed7a68 to
6fc4287
Compare
|
Thank you @fancyweb. |
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Jun 5, 2023
…(fancyweb) This PR was merged into the 7.0 branch. Discussion ---------- [Serializer] Remove abstract uid denormalization code | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Removes the code that was deprecated in #44721 Commits ------- 79028f9 [Serializer] Remove abstract uid denormalization code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #44600. All abstract classes should not be denormalized to Uuid::class. We need a concrete class. Instead of penalizing everyone with reflection in supportsDenormalization(), let's just bubble up the PHP \Error (we are going to do the same in UidValueResolver).