[Mime][Security] Fix missing sprintf and add tests #44822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4632643 to
0c66f91
Compare
derrabus
approved these changes
Dec 28, 2021
fabpot
approved these changes
Dec 28, 2021
|
Can you rebase on 5.3 an create another PR for the exception that did not exist back then? |
|
This PR is now only for AccessListener (6.0). #44824 for DkimSigner (5.3) Is it ok ? did I misunderstand ? |
fabpot
added a commit
that referenced
this pull request
Dec 28, 2021
This PR was squashed before being merged into the 5.3 branch. Discussion ---------- [Mime] Fix missing sprintf in DkimSigner | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | #44822 has 2 targets (5.3 for DkimSigner, 6.0 for AccessListener) Commits ------- 52ceda7 [Mime] Fix missing sprintf in DkimSigner
fabpot
approved these changes
Dec 28, 2021
ea4e72f to
c1954f8
Compare
|
Thank you @alamirault. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#44808 fix one missing sprintf. This PR fix other cases and add tests.