-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Notifier] Added 46elks notifier bridge #44874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test is failing due to the transport is named |
src/Symfony/Component/Notifier/Bridge/FortysixElks/FortysixElksTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/FortysixElks/FortysixElksTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/FortysixElks/FortysixElksTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/FortysixElks/FortysixElksTransportFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/FortysixElks/Tests/success-response.json
Outdated
Show resolved
Hide resolved
@symfony/mergers how do we proceed with the class naming? Thanks |
Awesome. Thank you. Could you add this package to the root composer.json's About the naming... Hm.. Im not sure. If you dont mind, I suggest to rename the transport to |
Did I understand you correctly about replace @Nyholm? I made the test pass by ignoring this transport. I think it's a (slightly) better solution than renaming the transport to something that is not the service/company name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could go either way.
I saw now that there already were some exceptions in that test.
I’m happy with this pr
@Nyholm I am not sure about the replace section 🧐 |
@OskarStark you are correct. It should not be in the composer's replace section. The CI job was wrong. I've updated the CI job in #44894 |
Thanks Tobias! |
8d8d89b
to
b08871f
Compare
Squashed and rebased. @Nyholm @OskarStark |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
random comment :)
src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/FortysixElks/Tests/FortysixElksTransportTest.php
Outdated
Show resolved
Hide resolved
670bea8
to
c614f0a
Compare
FortySix or Fortysix |
If we use letters instead of numbers, that would be In any case, we need to be consistent and only use one or the other, not both. |
d48e53c
to
52795da
Compare
Renamed classes and transport. Some places still refers to 46elks but that's more about the company rather than the implementation. But some are in between and I'm not sure what to use 🤷 |
src/Symfony/Component/Notifier/Bridge/FortySixElks/Tests/FortySixElksTransportFactoryTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/FortySixElks/FortySixElksTransportFactory.php
Outdated
Show resolved
Hide resolved
Regarding naming, isn't |
@jongotlin the textual version of 46 is |
@stof, ok thanks. Didn't know. |
8479295
to
1594296
Compare
Thank you @jongotlin. |
46elks is a Swedish sms provider.