Skip to content

[Notifier] Added 46elks notifier bridge #44874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Conversation

jongotlin
Copy link
Contributor

Q A
Branch? 6.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR symfony/symfony-docs#16350

46elks is a Swedish sms provider.

@jongotlin
Copy link
Contributor Author

Test is failing due to the transport is named 46elks but classes are named FortysixElks.... Shall I rename the transport to fortysix-elks or alter FrameworkExtensionTest somehow?

@OskarStark
Copy link
Contributor

@symfony/mergers how do we proceed with the class naming? Thanks

@Nyholm
Copy link
Member

Nyholm commented Jan 2, 2022

Awesome. Thank you.

Could you add this package to the root composer.json's replace section? I would also like to see fabbot.io happy (just some CS)

About the naming... Hm.. Im not sure. If you dont mind, I suggest to rename the transport to fortysix-elks or similar so the test passes.

@jongotlin
Copy link
Contributor Author

Did I understand you correctly about replace @Nyholm?

I made the test pass by ignoring this transport. I think it's a (slightly) better solution than renaming the transport to something that is not the service/company name.

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could go either way.

I saw now that there already were some exceptions in that test.

I’m happy with this pr

@OskarStark
Copy link
Contributor

@Nyholm I am not sure about the replace section 🧐

@Nyholm
Copy link
Member

Nyholm commented Jan 3, 2022

@Nyholm I am not sure about the replace section 🧐

Oh. I was just reading the CI output. I thought we did that for all bridges. See the job

@fancyweb Maybe we did a misstake here?

@Nyholm
Copy link
Member

Nyholm commented Jan 3, 2022

@OskarStark you are correct. It should not be in the composer's replace section. The CI job was wrong. I've updated the CI job in #44894

@OskarStark
Copy link
Contributor

Thanks Tobias!

@jongotlin
Copy link
Contributor Author

Squashed and rebased. @Nyholm @OskarStark

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

random comment :)

@carsonbot carsonbot changed the title Added 46elks notifier bridge [Notifier] Added 46elks notifier bridge Jan 4, 2022
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jan 4, 2022

FortySix or Fortysix
But also 46 or fortysix or forty-six in the package name (and maybe in the service name of course)

@fabpot
Copy link
Member

fabpot commented Jan 5, 2022

If we use letters instead of numbers, that would be FortySix (F and S uppercased), and so forty-six for the package name and where we need underscore names.

In any case, we need to be consistent and only use one or the other, not both.

@jongotlin
Copy link
Contributor Author

Renamed classes and transport. Some places still refers to 46elks but that's more about the company rather than the implementation. But some are in between and I'm not sure what to use 🤷

@jongotlin
Copy link
Contributor Author

Regarding naming, isn't fortysix-elks more correct than forty-six-elks? It is referring to 46 and not 40 6.

@stof
Copy link
Member

stof commented Jan 13, 2022

@jongotlin the textual version of 46 is forty-six, not fortysix

@jongotlin
Copy link
Contributor Author

@stof, ok thanks. Didn't know.

@fabpot
Copy link
Member

fabpot commented Jan 18, 2022

Thank you @jongotlin.

@fabpot fabpot merged commit 6153815 into symfony:6.1 Jan 18, 2022
@jongotlin jongotlin deleted the 46elks-notifier branch January 18, 2022 07:16
@fabpot fabpot mentioned this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants