Skip to content

[Serializer] Fix AbstractObjectNormalizer TypeError on denormalization #44881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[Serializer] Fix AbstractObjectNormalizer TypeError on denormalization #44881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d3da31
ticket_44872 added unit test to reproduce #44872
JustDylan23 Dec 31, 2021
e7412ad
ticket_44872 made the behavior of the recursive denormalizer the same…
JustDylan23 Jan 3, 2022
e102f02
ticket_44872 implemented PR feedback
JustDylan23 Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ protected function isAllowedAttribute(object|string $classOrObject, string $attr
* Normalizes the given data to an array. It's particularly useful during
* the denormalization process.
*/
protected function prepareForDenormalization(object|array|null $data): array
protected function prepareForDenormalization(mixed $data): array
{
return (array) $data;
}
Expand Down
12 changes: 12 additions & 0 deletions src/Symfony/Component/Serializer/Tests/Normalizer/AbstractNormalizerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase;
use Symfony\Component\PropertyInfo\Extractor\PhpDocExtractor;
use Symfony\Component\PropertyInfo\Extractor\ReflectionExtractor;
use Symfony\Component\Serializer\Encoder\JsonEncoder;
use Symfony\Component\Serializer\Mapping\AttributeMetadata;
use Symfony\Component\Serializer\Mapping\ClassMetadata;
Expand Down Expand Up @@ -217,4 +218,15 @@ public function testIgnore()

$this->assertSame([], $normalizer->normalize($dummy));
}

public function testDenormalizeRecursiveWithObjectAttributeWithStringValue()
{
$extractor = new ReflectionExtractor();
$normalizer = new ObjectNormalizer(null, null, null, $extractor);
$serializer = new Serializer([$normalizer]);

$obj = $serializer->denormalize(['inner' => 'foo'], ObjectOuter::class);

$this->assertInstanceOf(ObjectInner::class, $obj->getInner());
}
}