-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Serializer] Fix AbstractObjectNormalizer TypeError on denormalization #44908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey! I think @Th3Mouk has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix 👍
It would still makes more sense to me if the test was in |
I moved it 👍 |
are the tests that are failing now something on my end? I could rebase on 6.0 if desired |
Thanks. The tests look good to me. |
Thank you @JustDylan23. |
When using dependency injection to get the serializer (instead of manually instantiating it) the object normalizer that is injected into that serializer throws a value exception when doing denormalizing the following:
This throws
Refer to: #44881 for the description.
Was in the middle of changing the base branch and accidentally pushed when the branch was deleted.
@fancyweb I implemented the requested changes