-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[DependencyInjection] Fix nested env var with resolve processor #44932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
IMHO this is correct behavior. It took some time to understand why the workaround was needed, when reviewing a PR on our side. Im not sure about changing the behavior in a patch release. 6.1 + changelog works for us 👍 |
I first did it on 6.1 but then you said it's a bug in your opinion so i followed the rules and switch to 4.4 to make this PR 😁 |
d7b27c5
to
7de47ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me as a bugfix, thanks for the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's some nice tests 👏
Thanks for fixing this bug Laurent. |
This PR fixes the issue raised by @ro0NL. (see Description)
I added some tests but i'm not confident about how to check with real environment variables.
This is my first PR, i hope i'm not doing it wrong.