Skip to content

[FrameworkBundle] Avoid calling rtrim(null, '/') in AssetsInstallCommand #44976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2022
Merged

[FrameworkBundle] Avoid calling rtrim(null, '/') in AssetsInstallCommand #44976

merged 1 commit into from
Jan 12, 2022

Conversation

pavol-tuka
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
License MIT

Avoid following deprecation notice:

php.INFO: Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated

@carsonbot carsonbot added this to the 4.4 milestone Jan 10, 2022
GromNaN
GromNaN reviewed Jan 10, 2022
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix. The warning is on PHP 8.1, right?
#41552

@carsonbot carsonbot changed the title Avoid calling rtrim(null, '/') in AssetsInstallCommand [FrameworkBundle] Avoid calling rtrim(null, '/') in AssetsInstallCommand Jan 10, 2022
@pavol-tuka
Copy link
Contributor Author

It was symfony 5.4 project running on PHP 8.0 which log that to deprecations.log.

GromNaN
GromNaN approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR.

@GromNaN
Copy link
Member

GromNaN commented Jan 12, 2022 •
edited
Loading

... and one more bug fixed, thank you Pavol.

@GromNaN GromNaN merged commit c7a5902 into symfony:4.4 Jan 12, 2022
This was referenced Jan 28, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN approved these changes

Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@pavol-tuka @GromNaN @derrabus @carsonbot