-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Routing] Allow using UTF-8 parameter names #45054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nicolas-grekas
commented
Jan 18, 2022
Q | A |
---|---|
Branch? | 6.1 |
Bug fix? | no |
New feature? | yes |
Deprecations? | no |
Tickets | Fix #41909 |
License | MIT |
Doc PR | - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we add a changelog entry?
814b66a
to
80a87c8
Compare
Updated, thanks for the review. |
A test could be added to |
This is already covered by the current test to me. |
The change in |
80a87c8
to
dfd852d
Compare
Tests added @stof |
Thank you @nicolas-grekas. |