[PropertyInfo] Add PHP 8.0 promoted properties @param mutation support to PhpDocExtractor #45062
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By definition, PHP 8 promoted properties are declared in the constructor. Therefore, a new particular case raises when trying to extract (using PhpDocExtractor) a promoted property that is mutated via
@param
in the constructor.$promotedAndMutatedProperty
extracted types is currently[null]
(because of "mixed"), but IMO should be[string]
.However, I'm not sure if this is the intended behaviour for everyone (opinions welcomed). If it is, I guess I should update PhpDocExtractorTest as well to reflect the new priorities ?