[Console] fix parsing escaped chars in StringInput #45088
Conversation
nicolas-grekas
commented
Jan 20, 2022
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #32182 |
| License | MIT |
| Doc PR | - |
4080ad8 to
7cec761
Compare
7cec761 to
f0a89ec
Compare
|
Thank you @nicolas-grekas. |
This PR was merged into the 4.4 branch. Discussion ---------- [Console] Revert StringInput bc break from #45088 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix bobthecow/psysh#703 | License | MIT | Doc PR | - Fix a backwards compatibility break introduced in #45088 and released in v4.4.37, v5.3.14, v5.4.3 and v6.0.3. I went with `REGEX_UNQUOTED_STRING` by analog to the `REGEX_QUOTED_STRING` constant name, but don't have a strong opinion on what it should be called :) Commits ------- aab2f2a [Console] Revert StringInput bc break from #45088
* 4.4: [PropertyAccess] Fix handling of uninitialized property of parent class [DomCrawler] ignore bad charsets [Validator] Fix minRatio and maxRatio when getting rounded [Console] Revert StringInput bc break from #45088 [Form] Do not fix URL protocol for relative URLs [Serializer] make XmlEncoder stateless thus reentrant
* 5.4: [PropertyAccess] Fix handling of uninitialized property of parent class [DomCrawler] ignore bad charsets [Validator] Fix minRatio and maxRatio when getting rounded [Console] Revert StringInput bc break from #45088 [Form] Do not fix URL protocol for relative URLs [Serializer] make XmlEncoder stateless thus reentrant
* 6.0: [PropertyAccess] Fix handling of uninitialized property of parent class [DomCrawler] ignore bad charsets [Validator] Fix minRatio and maxRatio when getting rounded [Console] Revert StringInput bc break from #45088 [Form] Do not fix URL protocol for relative URLs [Serializer] make XmlEncoder stateless thus reentrant
|
@fabpot thanks! will we be getting a v5.3.x release for this as well? |
|
This patch was released in 5.3.14. I guess you're talking about #45240: this one won't be released for 5.3 since 5.3 is no longer maintained, check https://symfony.com/releases/5.3. |
|
Right, I get that, but this backwards compatibility break was released for 5.3 so we kind of need to fix it. |
We don't. A branch does not have to be bug-free at the time we stop supporting it. |
|
You're right, "need to" was the wrong choice of words. A backwards compatibility break was pushed in a 5.3.x release just before the end of the support window. I realized it and sent a fix, also just before the end of the support window. For some reason the fix wasn't released for a month. It would be negligent to not revert the BC break in a one off exception to the support policy, or yank the affected releases. I don't particularly care which it is :) |
|
That's an edge case :) The last version was released on January 28. You fixed it on January 29 but I didn't realize it was a BC fix because I wasn't aware of the PR. Anyway, this is the kind of special case where we need to do something. I will see if I can do a 5.3 release. |
|
Just to add more info: The end of maintenance date is "somewhere at the end of the month" and not "the last day of the month". So, other core team members who commented on this issue were right. But, in the past, whenever we broke BC in the very last release of a minor version, we cherry-picked the fix and made one very last release. That's what I'm going to do here. (Just wanted to make sure that it's not interpreted as an open door to back-port all the bug fixes) |
|
That's entirely reasonable. Thanks for the consideration. |
This PR was merged into the 5.3 branch. Discussion ---------- [Console] Revert StringInput bc break from #45088 | Q | A | ------------- | --- | Branch? | 5.3 <!-- see below --> | Bug fix? | yes (BC break) | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Refs #45088<!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | n/a Commits ------- e978194 [Console] Revert StringInput bc break from #45088
|
Console v5.3.16 released. |
* 5.3: Update VERSION for 5.3.16 Update CHANGELOG for 5.3.16 [Console] Revert StringInput bc break from #45088
* 5.4: Update VERSION for 5.3.16 Update CHANGELOG for 5.3.16 [Console] Revert StringInput bc break from #45088 [FrameworkBundle] require ext-sodium in tests [HttpClient] fix checking for unset property on PHP <= 7.1.4
* 6.0: Update VERSION for 5.3.16 Update CHANGELOG for 5.3.16 [Console] Revert StringInput bc break from #45088 [FrameworkBundle] require ext-sodium in tests [HttpClient] fix checking for unset property on PHP <= 7.1.4