[Finder] Fix finding VCS re-included files in excluded directory #45095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a43190 to
d108ac5
Compare
|
Thank you @julienfalque. |
|
Thanks for merging @nicolas-grekas! What's your opinion about returning the directory as well (see #45095 (comment))? |
|
I don't know, I'm not into that business :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where
Finderwould not return a file inside a directory when gitignore rules exclude the directory but re-include the file.The first commit makes
Finderreturn the file. Though, as shown by the second commit, the directory is still not returned. Strictly speaking, the directory is ignored, so in some senseFinderis correct. But then it contains a file that is not ignored. In this case, Git would see the directory anyway. ShouldFinderreturn any ignored directory as soon as it contains a file that is not ignored? Even if that file is not part ofFinderresults?