Skip to content

[DependencyInjection] Fix tests on PHP 7.1 #45156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2022
Merged

[DependencyInjection] Fix tests on PHP 7.1 #45156

merged 1 commit into from
Jan 24, 2022

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Jan 24, 2022 •
edited
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Should make Appveyor green. The object typehint is 7.2+.

@carsonbot carsonbot added this to the 4.4 milestone Jan 24, 2022
@carsonbot carsonbot changed the title [DI] Fix tests on PHP 7.1 [DependencyInjection] Fix tests on PHP 7.1 Jan 24, 2022
@stof
Copy link
Member

stof commented Jan 24, 2022

Wasn't this precisely meant to test support for using object in bindings ? If yes, we should skip the test on PHP 7.1 instead of removing the proper testing.

@chalasr
Copy link
Member Author

chalasr commented Jan 24, 2022 •
edited
Loading

Not really, it's meant to cover bindings on inline services (#45063). Still, PR updated to skip the test on PHP<7.2.

@nicolas-grekas
Copy link
Member

Thank you @chalasr.

@nicolas-grekas nicolas-grekas merged commit 7eea1cb into symfony:4.4 Jan 24, 2022
@chalasr chalasr deleted the di-test-7.1 branch January 24, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug DependencyInjection Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@chalasr @stof @nicolas-grekas @carsonbot