-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Console] Fix PHP 8.1 deprecation in ChoiceQuestion #45181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for 4.4 (my bad - no worry, we can switch the branch while merging).
Thanks for doing your first PR on Symfony!
src/Symfony/Component/Console/Tests/Question/ChoiceQuestionTest.php
Outdated
Show resolved
Hide resolved
Can you fix fabbot's report also? (see CI checks) |
Done too. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For 4.4
Thank you @brokensourcecode. |
Linking #41552 to keep track of PHP 8.1 fixes. |
6.04.4 for bug fixes