-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[PhpUnitBridge] Add option ignoreFile
to configure a file that lists deprecation messages to ignore
#45226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mondrake
commented
Jan 28, 2022
Q | A |
---|---|
Branch? | 6.1 |
Bug fix? | no |
New feature? | yes |
Deprecations? | no |
Tickets | Fix #45223 |
License | MIT |
Doc PR | symfony/symfony-docs#... |
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
Hey! I think @l-vo has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
cc @greg0ire |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests.
src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Configuration.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Configuration.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Configuration.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Configuration.php
Outdated
Show resolved
Hide resolved
I am not familiar with Symfony's test suite. I'll try to have a look, in the meantime any pointer appreciated. |
@greg0ire I have added a couple of tests. |
src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/ConfigurationTest.php
Show resolved
Hide resolved
src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/ConfigurationTest.php
Show resolved
Hide resolved
@greg0ire I think the test coverage is now complete |
Added an integration test. |
src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/ConfigurationTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/ConfigurationTest.php
Outdated
Show resolved
Hide resolved
…s deprecation messages to ignore
ignoreFile
to configure a file that lists deprecation messages to ignore
Thank you @mondrake. |
Thanks for the issues. Would you be able to send fixes? |
Will try! |
#45918 and #45919 got fixed, thanks @nicolas-grekas! Anyone interested, a working issue to get the ignoreFile implemented in Drupal core: [Symfony 6.1] Replace deprecationListenerTrait with PHPUnitBridge ignoreFile |