Skip to content

[PhpUnitBridge] Add option ignoreFile to configure a file that lists deprecation messages to ignore #45226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

mondrake
Copy link
Contributor

Q A
Branch? 6.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #45223
License MIT
Doc PR symfony/symfony-docs#...

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@mondrake mondrake changed the title PHPUnitBridge - Add ignoreFile PHPUnitBridge - Add deprecations ignoreFile Jan 28, 2022
@carsonbot
Copy link

Hey!

I think @l-vo has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@OskarStark
Copy link
Contributor

cc @greg0ire

Copy link
Contributor

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests.

@mondrake
Copy link
Contributor Author

Please add tests.

I am not familiar with Symfony's test suite. I'll try to have a look, in the meantime any pointer appreciated.

@mondrake
Copy link
Contributor Author

@greg0ire I have added a couple of tests.

@mondrake
Copy link
Contributor Author

@greg0ire I think the test coverage is now complete

@mondrake
Copy link
Contributor Author

Added an integration test.

@carsonbot carsonbot changed the title PHPUnitBridge - Add deprecations ignoreFile [PhpUnitBridge] PHPUnitBridge - Add deprecations ignoreFile Mar 31, 2022
@nicolas-grekas nicolas-grekas changed the title [PhpUnitBridge] PHPUnitBridge - Add deprecations ignoreFile [PhpUnitBridge] Add deprecations ignoreFile Mar 31, 2022
@nicolas-grekas nicolas-grekas changed the title [PhpUnitBridge] Add deprecations ignoreFile [PhpUnitBridge] Add option ignoreFile to configure a file that lists deprecation messages to ignore Mar 31, 2022
@nicolas-grekas
Copy link
Member

Thank you @mondrake.

@mondrake
Copy link
Contributor Author

mondrake commented Apr 2, 2022

A couple of glitches: #45918, #45919

@nicolas-grekas
Copy link
Member

Thanks for the issues. Would you be able to send fixes?

@mondrake
Copy link
Contributor Author

mondrake commented Apr 2, 2022

Will try!

@mondrake
Copy link
Contributor Author

mondrake commented Apr 3, 2022

#45918 and #45919 got fixed, thanks @nicolas-grekas!

Anyone interested, a working issue to get the ignoreFile implemented in Drupal core: [Symfony 6.1] Replace deprecationListenerTrait with PHPUnitBridge ignoreFile

@fabpot fabpot mentioned this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHPUnitBridge - add a deprecation 'ignoreFile option' to allow silencing deprecation patterns
6 participants