[Routing] fix encoding of static text #4530
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github tells me this PR cannot be merged automatically. Could you rebase it ? |
…id URLs also added test with many special characters
|
Done |
fabpot
added a commit
that referenced
this pull request
Jul 3, 2012
Commits ------- 3466896 [Routing] fix encoding of static static, so UrlGenerator produces valid URLs Discussion ---------- [Routing] fix encoding of static text Fixes #4166 As requested by Fabien, I split #4205 into multiple PRs. --------------------------------------------------------------------------- by stof at 2012-06-09T12:49:32Z github tells me this PR cannot be merged automatically. Could you rebase it ? --------------------------------------------------------------------------- by Tobion at 2012-06-09T13:12:55Z Done --------------------------------------------------------------------------- by travisbot at 2012-06-09T13:18:18Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1576266) (merged 3466896 into 15b5aa4).
|
merged, thanks. |
|
I've merged this into master instead of 2.0 by mistake. |
|
So do you want to include this in 2.0? |
|
No, I think master is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4166
As requested by Fabien, I split #4205 into multiple PRs.