Skip to content

[Cache] Mention parameter type in phpdoc explicitly #45324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

andrew-demb
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

@andrew-demb andrew-demb changed the title Mention parameter type in phpdoc explicitly [Cache] Mention parameter type in phpdoc explicitly Feb 5, 2022
@derrabus derrabus added this to the 4.4 milestone Feb 5, 2022
@derrabus derrabus added the Cache label Feb 5, 2022
@nicolas-grekas
Copy link
Member

The type is optional, so that this should not be required.
See https://docs.phpdoc.org/3.0/guide/references/phpdoc/tags/param.html

If you're using a parser that mandates the type, you might want to open an issue there.

@andrew-demb
Copy link
Contributor Author

Yes, the type is optional.
But omitting type is not consistent with Symfony codebase.

So I don't know a reason to not specify it.

@nicolas-grekas
Copy link
Member

I would say that the Symfony code-style is to not duplicate into phpdoc info that is already found in the signature.
We cleaned up a lot of phpdoc thanks to php8 on branches >= 5.4.
I'm closing therefore, thanks for submitting.

@andrew-demb andrew-demb deleted the patch-2 branch February 8, 2022 10:55
@wouterj wouterj mentioned this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants