[Runtime] Fix dotenv_overload with commands #45426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f4266f9 to
f9de6bc
Compare
f9de6bc to
4075269
Compare
|
Thank you @fancyweb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bugs introduced in #44997.
For example, if
$_SERVER['APP_ENV'] = 'foo';exists and withAPP_ENV=prodin.env, any command will throwCannot use "--env" or "-e" when the...becausefoois considered as the input env.Determining the input env and debug from
$_SERVERis wrong because when the--no-debugand--envare not used, we actually consider the existing env and debug as the input end and debug. We need to know and use the real input env and debug.