[HttpKernel] Controller Attributes #45457
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
jvasseur
reviewed
Feb 17, 2022
| namespace Symfony\Component\HttpKernel\Attribute; | ||
|
|
||
| /** | ||
| * Marker interface for controller attributes |
There was a problem hiding this comment.
For controller argument attributes we decided to remove the marker interface, should we do the same here ?
There was a problem hiding this comment.
No marker at all, the same way controller argument metadata works. We might need to introduce a ControllerMetadata class to mirror the ArgumentMetadata one.
ro0NL
reviewed
Feb 17, 2022
|
|
||
| namespace Symfony\Component\HttpKernel\EventListener; | ||
|
|
||
| use Doctrine\Persistence\Proxy; |
|
I'm closing in favor of #46001, which should provide a better starting point for the goal we have. |
chalasr
added a commit
that referenced
this pull request
Jul 7, 2022
… handle attributes on controllers (nicolas-grekas) This PR was squashed before being merged into the 6.2 branch. Discussion ---------- [HttpKernel] Add `ControllerEvent::getAttributes()` to handle attributes on controllers | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Replacing #45457. Paving the way toward #44705 Commits ------- 0f2293c [HttpKernel] Add `ControllerEvent::getAttributes()` to handle attributes on controllers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a continuation of efforts to deprecate SensioFrameworkExtraBundle (#45415), this PR adds a mechanism to parse controller attributes at the request of @nicolas-grekas.
This is a rewrite of the ControllerListener from SensioFrameworkExtraBundle with support for annotations dropped.
The only thing I haven't implemented is a configuration option in FrameworkBundle to enable/disable support. I'm thinking of either
framework.controller.controller_attributesorframework.request.controller_attributes, any suggestions?