Skip to content

[Validator] Improve tests for the Image and File constraints #45511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2022
Merged

[Validator] Improve tests for the Image and File constraints #45511

merged 1 commit into from
Feb 24, 2022

Conversation

fancyweb
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? -
Tickets -
License MIT
Doc PR -

For #45090 but submitting it on the lowest branch possible.

@carsonbot carsonbot added this to the 4.4 milestone Feb 22, 2022
@fancyweb fancyweb mentioned this pull request Feb 22, 2022
Merged
@fancyweb fancyweb force-pushed the validator/image-test branch from caed8c3 to 8a08731 Compare February 22, 2022 13:54
@fancyweb fancyweb force-pushed the validator/image-test branch from 8a08731 to 1a82c71 Compare February 22, 2022 13:55
@fancyweb fancyweb changed the title [Validator] Add invalid mime type test for the Image constraint [Validator] Improve tests for the Image and File constraints Feb 22, 2022
@nicolas-grekas
Copy link
Member

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas merged commit 392d88e into symfony:4.4 Feb 24, 2022
@fancyweb fancyweb deleted the validator/image-test branch February 24, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review Validator
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@fancyweb @nicolas-grekas @carsonbot