Skip to content

[BrowserKit] Add toArray to Response #45515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2022
Merged

[BrowserKit] Add toArray to Response #45515

merged 1 commit into from
Mar 9, 2022

Conversation

HypeMC
Copy link
Member

@HypeMC HypeMC commented Feb 23, 2022

Q A
Branch? 6.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR TODO

Adds a toArray method to BrowserKit's Response similar to the one in HttpClient. Is useful when working with json responses.

@carsonbot carsonbot added this to the 6.1 milestone Feb 23, 2022
@HypeMC HypeMC force-pushed the add-toarray-to-browserkit-response branch from 5d1d712 to ee8fcc3 Compare February 23, 2022 00:03
@carsonbot
Copy link

Hey!

I think @alexander-schranz has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

OskarStark
OskarStark reviewed Feb 25, 2022
View reviewed changes
@HypeMC HypeMC force-pushed the add-toarray-to-browserkit-response branch from ee8fcc3 to a63fe22 Compare February 25, 2022 06:55
rodnaph
rodnaph reviewed Feb 26, 2022
View reviewed changes
@nicolas-grekas
Copy link
Member

LGTM, can you please have a look at @rodnaph's comments?

@HypeMC HypeMC force-pushed the add-toarray-to-browserkit-response branch from a63fe22 to 19e2e3a Compare March 5, 2022 08:11
nicolas-grekas
nicolas-grekas approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on my side, with or without private array $jsonData; (I don't have any data to decide if one is better than the other).

@fabpot
Copy link
Member

fabpot commented Mar 9, 2022

Thank you @HypeMC.

@fabpot fabpot mentioned this pull request Mar 9, 2022
Closed
@fabpot fabpot merged commit 3c2c068 into symfony:6.1 Mar 9, 2022
@HypeMC HypeMC deleted the add-toarray-to-browserkit-response branch March 9, 2022 08:20
@fabpot fabpot mentioned this pull request Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodnaph rodnaph rodnaph left review comments

@OskarStark OskarStark OskarStark left review comments

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@yceruto yceruto yceruto approved these changes

Assignees
No one assigned
Labels
BrowserKit Feature Status: Reviewed
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
7 participants
@HypeMC @carsonbot @nicolas-grekas @fabpot @rodnaph @OskarStark @yceruto