Fix deprecations on PHP 8.2 #45532
Merged
Fix deprecations on PHP 8.2 #45532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Feb 23, 2022
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | On the road to #44282 |
| License | MIT |
| Doc PR | - |
derrabus
approved these changes
Feb 24, 2022
b169934 to
048307f
Compare
048307f to
ca56620
Compare
|
Code is now 100% deprecation-free on PHP 8.2. |
derrabus
reviewed
Feb 25, 2022
| new \DatePeriod('R4/2012-07-01T00:00:00Z/P7D'), | ||
| ]]; | ||
|
|
||
| $value = \PHP_VERSION_ID >= 70406 ? new ArrayObject() : new \ArrayObject(); |
There was a problem hiding this comment.
I'm curious, what's the reason for this version check?
There was a problem hiding this comment.
PHP 8.2 needs the attribute for this test but I also want to keep a test that creates a native ArrayObject.
There was a problem hiding this comment.
Oh, I see. That version number 7.4.6 seemed so oddly specific that I though I had missed something in PHP's ChangeLog. 😅
29 tasks
This was referenced Mar 5, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.