Skip to content

[Translation] Extract locale fallback computation into a dedicated class #45553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: 7.4
Choose a base branch
from
+222 −62
Open

[Translation] Extract locale fallback computation into a dedicated class #45553

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
aa6a433
Extract locale fallback computation into a dedicated class
mpdude Feb 24, 2022
2afae5e
Add FallbackLocaleProviderInterface
mpdude Feb 28, 2022
54e6a4a
Move locale validation out of Translator and use it to validate local…
mpdude Feb 28, 2022
042757a
Add a constructor for FallbackLocaleProvider
mpdude Feb 28, 2022
2455bac
Add a CHANGELOG entry
mpdude Feb 28, 2022
532a72c
Make FrameworkBundle configure FallbackLocaleProvider in the container
mpdude Feb 28, 2022
47fe72a
Try to get away without requirement bumps in FrameworkBundle
mpdude Feb 28, 2022
0c19e4f
Update CHANGELOG as suggested in GH Review
mpdude Aug 1, 2022
c2ac4a2
Rename method as suggested in GH Review
mpdude Aug 1, 2022
ddb9462
Make the FallbackLocaleProvider immutable; create new instances when …
mpdude Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Try to get away without requirement bumps in FrameworkBundle
  • Loading branch information
@mpdude
mpdude committed Feb 28, 2022
commit 47fe72ae82cf82699c1ef7224f431d1b5dc4b87e
11 changes: 7 additions & 4 deletions src/Symfony/Bundle/FrameworkBundle/Resources/config/translation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
'debug' => param('kernel.debug'),
],
abstract_arg('enabled locales'),
service('translation.fallback_locale_provider')
service('translation.fallback_locale_provider')->ignoreOnInvalid(),
])
->call('setConfigCacheFactory', [service('config_cache_factory')])
->tag('kernel.locale_aware')
Expand All @@ -78,9 +78,6 @@
->set('translator.formatter.default', MessageFormatter::class)
->args([service('identity_translator')])

->set('translation.fallback_locale_provider', FallbackLocaleProvider::class)
->alias(FallbackLocaleProviderInterface::class, 'translation.fallback_locale_provider')

->set('translation.loader.php', PhpFileLoader::class)
->tag('translation.loader', ['alias' => 'php'])

Expand Down Expand Up @@ -169,4 +166,10 @@
->tag('container.service_subscriber', ['id' => 'translator'])
->tag('kernel.cache_warmer')
;

if (class_exists(FallbackLocaleProvider::class)) {
$container->services()
->set('translation.fallback_locale_provider', FallbackLocaleProvider::class)
->alias(FallbackLocaleProviderInterface::class, 'translation.fallback_locale_provider');
}
};