[HttpClient] Remove credentials from requests redirected to same host but different port #45616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… but different port
|
Hey! I think @matthieumota has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
fabpot
approved these changes
Mar 4, 2022
|
Thank you @nicolas-grekas. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rfc-editor.org/rfc/rfc6265#section-1
rfc-editor.org/rfc/rfc6265#section-8.5
In this PR, we propose to make HttpClient stricter as of version 6.1, by enforcing that the port also matches when automatically following redirections.
Patch courtesy of @GromNaN