Skip to content

[Runtime] Fix passing $debug parameter to ErrorHandler #45675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2022
Merged

[Runtime] Fix passing $debug parameter to ErrorHandler #45675

merged 1 commit into from
Mar 8, 2022

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Mar 8, 2022

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? yes/no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

As discussed with @nicolas-grekas on Slack, we think we should pass $debug parameter instead of true, since the 2nd argument of ErrorHandler is called $debug.

@nicolas-grekas
Copy link
Member

Thank you @Kocal.

@nicolas-grekas nicolas-grekas merged commit daa8283 into symfony:5.4 Mar 8, 2022
@Kocal Kocal deleted the patch-1 branch March 8, 2022 15:45
This was referenced Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants