Skip to content

[Security] Fix return value of NullToken::getUser() #45697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2022
Merged

[Security] Fix return value of NullToken::getUser() #45697

merged 1 commit into from
Mar 12, 2022

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Mar 10, 2022 •
edited
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets #44909
License MIT
Doc PR -

We went back & forth on this one but according to the history, we've just forgot to do it in #42650.
Note: it's already null on 6.0+

@chalasr chalasr requested a review from wouterj as a code owner March 10, 2022 09:14
@carsonbot carsonbot added this to the 5.4 milestone Mar 10, 2022
@chalasr chalasr mentioned this pull request Mar 10, 2022
Closed
@carsonbot carsonbot changed the title Fix return value of NullToken::getUser() [Security] Fix return value of NullToken::getUser() Mar 10, 2022
@fabpot
Copy link
Member

fabpot commented Mar 12, 2022

Thank you @chalasr.

@fabpot fabpot merged commit 486a39c into symfony:5.4 Mar 12, 2022
@chalasr chalasr deleted the nulltoken-nulluser branch March 13, 2022 16:08
This was referenced Apr 2, 2022
Merged
Merged
chalasr referenced this pull request in symfony/security-core Apr 25, 2022
@chalasr
Fix return value of NullToken::getUser()
1468230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh xabbuh approved these changes

@wouterj wouterj Awaiting requested review from wouterj

Assignees
No one assigned
Labels
Bug Security Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@chalasr @fabpot @xabbuh @carsonbot